Remove JetBrains Client compatibility #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, issue & discussion started here: https://sourcegraph.slack.com/archives/C059N5FRYG3/p1706893662584919 |
mkondratek
approved these changes
Feb 8, 2024
Fixes #366 Fixes #537 Fixes https://github.com/sourcegraph/sourcegraph/issues/57569 Motivation: Multiple features are simply not working on this "thin" IDE (see: linked issues). JetBrains client is prefixed with "JBC" (for example: JBC-232.10227.8).
|
@kalanchan @taylorsperry |
mkondratek
added a commit
that referenced
this pull request
Oct 3, 2024
Reverts #540. We encountered an issue on when insallig the plugin on windows. Maybe we can remove it... (manual testing in progress) ## Test plan 1. Remote Dev works on windows (install plugin from disk on windows in remote dev)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366
Fixes #537
Fixes https://github.com/sourcegraph/sourcegraph/issues/57569
Motivation: Multiple features are simply not working on this "thin" IDE (see: linked issues) due to missing classes.
More details here: #537
JetBrains client is prefixed with "JBC" (for example: JBC-232.10227.8).
Test plan
You shouldn't be able to install Cody on JetBrains Client. It's hard to reproduce (I had issues to download & use this), however this can be simply verified on Cody plugin JetBrains Marketplace page > Versions > Compatible with... (currently JetBrains Client is listed there).