Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multi repo context #541

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Feb 8, 2024

Test plan

scenario 1

  1. runIde
  2. add "https://github.com/sourcegraph/sourcegraph"
  3. ask "what is squirrel"

scenario 2

  1. having steps 1 and 2 from the scenario 1 done
  2. close project
  3. open project
  4. ask "what is squirrel"

@mkondratek mkondratek self-assigned this Feb 8, 2024
@mkondratek mkondratek changed the title Use codebaseName for getRepository and getRepoIds requests fix: Multi repo context Feb 8, 2024
if (matchResult != null) {
val (host, owner, repo) = matchResult.destructured
val sshUrlRegexMatchResult =
Regex("""^[\w-]+@([^:]+):([\w-]+)/([\w-]+)(\.git)?$""").find(cloneURL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regex value hasnt changed, has it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, only the variable name

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit 6c47b51 into main Feb 8, 2024
2 checks passed
@mkondratek mkondratek deleted the mkondratek/fix/multi-repo-context branch February 8, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants