Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symf reindexing error notification #593

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

exigow
Copy link
Contributor

@exigow exigow commented Feb 12, 2024

Fixes #381

Test plan

a) Throw exception during symf indexing
b) ...or use codyCommit= sourcegraph/cody@9f6160a

Demo

report-symf

@exigow exigow self-assigned this Feb 12, 2024
@exigow exigow changed the title Fix symf indexing error notifications Fix symf re-indexing error notifications Feb 12, 2024
@exigow exigow changed the title Fix symf re-indexing error notifications Fix symf reindexing error notifications Feb 12, 2024
@exigow exigow changed the title Fix symf reindexing error notifications Fix symf reindexing error notification Feb 12, 2024
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exigow exigow merged commit 2445b0e into main Feb 12, 2024
2 checks passed
@exigow exigow deleted the exigow/fix-symf-error-notifications branch February 12, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GA: If search indexing fails, users are notified with guidance for debugging
2 participants