Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WorkspaceReferencesParams.query partial #9

Merged
merged 1 commit into from
Jan 8, 2017
Merged

Conversation

felixfbecker
Copy link

No description provided.

@slimsag
Copy link
Member

slimsag commented Jan 6, 2017

Where can I read about what this does? I Googled a little bit but only came up with mixins etc

@beyang
Copy link
Member

beyang commented Jan 6, 2017

@slimsag see discussion here: microsoft/TypeScript#4889.

I think this is not strictly necessary to make things typesafe, but it does provide a hint to the consumer of the spec that not all the fields have to be present in the query.

@felixfbecker
Copy link
Author

It makes all properties optional.
Docs here: https://www.typescriptlang.org/docs/handbook/advanced-types.html#mapped-types
In my case it is pretty important to know whether all fields I define (which includes a unqiue symbol ID) will be present or not, so I thought it would be good to clear it up in the spec

@slimsag
Copy link
Member

slimsag commented Jan 8, 2017

LGTM

@slimsag
Copy link
Member

slimsag commented Jan 8, 2017

Thanks for the links, BTW!

@slimsag slimsag merged commit 2686c4b into master Jan 8, 2017
@slimsag slimsag deleted the partial-query branch January 8, 2017 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants