fix: Convert loading panic -> error & delete index (#62)

sourcegraph · Oct 26, 2023 · 89c0adf · 89c0adf
1 parent acd1632
commit 89c0adf
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/cmd/scip-go/main.go b/cmd/scip-go/main.go
@@ -207,7 +207,20 @@ func mainErr() error {
 		}
 	}
 
+	removeOutFileIfPresent := func() {
+		if fileInfo, err := os.Stat(outFile); err == nil && fileInfo.Mode().IsRegular() {
+			os.RemoveAll(outFile)
+		}
+	}
+
+	defer func() {
+		if r := recover(); r != nil {
+			removeOutFileIfPresent()
+		}
+	}()
+
 	if err := index.Index(writer, options); err != nil {
+		removeOutFileIfPresent()
 		return err
 	}
 

diff --git a/internal/loader/loader.go b/internal/loader/loader.go
@@ -74,7 +74,12 @@ func LoadPackages(
 
 	projectPackages = make(PackageLookup)
 
-	if err := output.WithProgress("Loading Packages", func() error {
+	var panicResult any
+	err = output.WithProgress("Loading Packages", func() error {
+		defer func() {
+			panicResult = recover()
+		}()
+
 		cfg := getConfig(moduleRoot, opts)
 		pkgs, err := packages.Load(cfg, "./...")
 		if err != nil {
@@ -90,7 +95,12 @@ func LoadPackages(
 		}
 
 		return nil
-	}); err != nil {
+	})
+	if err == nil && panicResult != nil {
+		err = fmt.Errorf("during package loading: %v", panicResult)
+	}
+
+	if err != nil {
 		return nil, nil, err
 	}