fix: Correctly format logged errors during arg parsing #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, we don't log any errors at that time, but the old code would print inconsistent results which was a bit annoying. There is technically a circular dependency, since the verbosity level is determined during argument parsing, and it is needed to determine the correct logging level. Ignoring that as an edge case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we don't log any errors at that time,
but the old code would print inconsistent results
which was a bit annoying. There is technically a
circular dependency, since the verbosity level
is determined during argument parsing, and it
is needed to determine the correct logging level.
Ignoring that as an edge case.