fix: Index all test code in the current module #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-src
commented
Sep 24, 2024
Comment on lines
+1
to
+3
| package testspecial | ||
|
|
||
| func TestFoo_Whitebox() { Foo() } |
There was a problem hiding this comment.
As of the first commit, the snapshot test is (incorrectly) not generating foo_test.go in the output directory. This is fixed in the second commit.
varungandhi-src
force-pushed
the
vg/index-test-code
branch
from
ffd36db to
5c73fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is basically a one-liner; most of the diff is because of
snapshot changes. Fixes https://linear.app/sourcegraph/issue/GRAPH-866
With this patch, the scip-go index size for the Sourcegraph monorepo grows
from 4012 documents (144MB uncompressed) to 5422 documents (208MB).