Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse package patterns args #139

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Parse package patterns args #139

merged 1 commit into from
Nov 7, 2024
+17 −3

Conversation

podtserkovskiy
Copy link
Contributor

Added an option to specify what packages to index, the default behaviour is the same as before./...

scip-go ./... # index all recursively
scip-go std # index all stdlib
scip-go ./cmd/scip-go #index main scip-go cmd package
scip-go net/http fmt # index `net/http` and `fmt` packages
scip-go foo//bar:baz # index Buck/Bazel target
scip-go pattern=foo//... file=bar/baz.go # example of usage file and pattern queries

The doc: https://pkg.go.dev/golang.org/x/tools/go/packages#pkg-overview

Related: #3

@podtserkovskiy podtserkovskiy mentioned this pull request Oct 28, 2024
Closed
@varungandhi-src
Copy link
Contributor

Could you rebase on top of the main branch so that we can kick off CI?

varungandhi-src
varungandhi-src approved these changes Oct 30, 2024
View reviewed changes
cmd/scip-go/main.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/loader/loader.go Outdated Show resolved Hide resolved
@podtserkovskiy podtserkovskiy force-pushed the parse_package_patterns2 branch from 7efd7ee to 9fb72c4 Compare October 30, 2024 14:24
@podtserkovskiy
Copy link
Contributor Author

I've rebased on main, but unfortunately I don't see any CI signals triggered

@podtserkovskiy podtserkovskiy force-pushed the parse_package_patterns2 branch from 9fb72c4 to cef7a70 Compare October 31, 2024 17:37
@varungandhi-src varungandhi-src merged commit 7194bc6 into sourcegraph:main Nov 7, 2024
3 checks passed
@varungandhi-src
Copy link
Contributor

Thanks for the patch, merged now.

@podtserkovskiy
Copy link
Contributor Author

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varungandhi-src varungandhi-src varungandhi-src approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@podtserkovskiy @varungandhi-src