Skip to content

Support enclosing ranges for function definitions #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support enclosing ranges for function definitions #172

wants to merge 1 commit into from

Conversation

podtserkovskiy
Copy link
Contributor

@podtserkovskiy podtserkovskiy commented Oct 7, 2025 •
edited
Loading

Supported enclosing_range for function definitions only.

Introducing additional traversal with ast.PreorderStack, because ast.Walk doesn't allow to access information about enclosing nodes.
The implementation code would be a bit simpler if ast.PreorderStack be used for the main traversal.

For #92

This PR can be merged after sourcegraph/scip#343 merged and new release tag published, so we can use it here for snapshots.

This was referenced Oct 7, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@podtserkovskiy