Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release pipeline: Build all artifacts first, and only publish images+package on success #303

Open
varungandhi-src opened this issue Dec 22, 2023 · 2 comments

Comments

@varungandhi-src
Copy link
Contributor

Right now, we can end up in a state where we publish a package to npm but there is no matching Docker image because the image failed to build.

@varungandhi-src
Copy link
Contributor Author

Right now, the Docker images rely on the package being available and then installing that, instead of building the package locally. We can instead use npm pack. yarn add seems like it used to support installing from a tarball. https://classic.yarnpkg.com/lang/en/docs/cli/add/ However, the new Yarn version doesn't mention that a local filepath is supported. https://yarnpkg.com/cli/add 😮‍💨

@kritzcreek
Copy link
Contributor

Related to #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants