Fix protobuf generation #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
commented
Jul 21, 2023
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -euo pipefail | |||
| set -xeuo pipefail | |||
There was a problem hiding this comment.
Added -x to make it easier to debug what command failed
olafurpg
force-pushed
the
olafurpg/fix-build
branch
from
c90578a
to
a645f9a
Compare
Previously, the build was failing because of an HTTP error connecting to the buf plugin registry. This commit fixes the problem by replacing the buf Go plugin with the standard Go protobuf generator.
olafurpg
force-pushed
the
olafurpg/fix-build
branch
from
a645f9a
to
d24c8c9
Compare
varungandhi-src
approved these changes
Jul 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the build was failing because of an HTTP error connecting to the buf plugin registry. This commit fixes the problem by replacing the buf Go plugin with the standard Go protobuf generator.
Test plan
Green CI.