-
Notifications
You must be signed in to change notification settings - Fork 1.3k
codeintel: Replace SQLite with dgraph-io/badger #11052
Conversation
Codecov Report
@@ Coverage Diff @@
## tar-bundle-payloads #11052 +/- ##
====================================================
Coverage 46.34% 46.34%
====================================================
Files 1374 1374
Lines 77412 77412
Branches 6595 6595
====================================================
Hits 35875 35875
Misses 38130 38130
Partials 3407 3407
|
Is there an RFC for this change? The default memory footprint of badger is not small. Also it requires 64-bits system to compile (even though they claimed fixed this many times but I couldn't compile it on a 32-bit machine as of Jan or Feb this year). |
No, this is just an experiment. I plan to do measurements with a handful of different storage mechanisms and serialization techniques.
I'll do additional profiling to see if I can get it down. Is it necessary to compile on a 32-bit machine? |
e4ff1a4
to
02f3950
Compare
81c7dde
to
b75460e
Compare
402ea67
to
420d769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efritz I think sqlite is just really good at immutable data stores? When you benchmarked the performance, where did the issues lie? Is it possible it is just that we are always dominated by serialization so it doesn't really matter what the underlying store is?
No description provided.