This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
dev: update to go 1.15 #12960
Closed
dev: update to go 1.15 #12960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not checked but looks like a problem with Go 1.15 gofmt? https://sourcegraph.slack.com/archives/C07KZF47K/p1597266059316000 |
|
I will try and test this locally today. Should we also consider bumping the images at the same time? |
|
This change already bumps the go version that the agents use when building
the binaries for images
…On Thu, Aug 13, 2020 at 7:59 AM Dax McDonald ***@***.***> wrote:
I will try and test this locally today. Should we also consider bumping
the images at the same time?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/sourcegraph/sourcegraph/pull/12960#issuecomment-673529414>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE2UO3HJKWAT4UPSHVS3SDSAP5VJANCNFSM4P5WVBXA>
.
|
|
What's up with this PR? |
|
I believe this blocked us from upgrading golang/go#39568 |
|
@daxmc99: We'll need to update eventually. Can we ask our RDS customers to follow the steps described here during upgrade? golang/go#39568 (comment) |
|
See this PR as well https://github.com/sourcegraph/sourcegraph/pull/13433 |
|
I'm going to merge this PR with https://github.com/sourcegraph/sourcegraph/pull/13433 and work on finishing off the tasks there. |
|
Ping. What's blocking progress here? @sourcegraph/distribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @sourcegraph/cloud