This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
EventLogger: Return sourcegraph.com hostname only for internal referrers #22864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malomarrec
suggested changes
Jul 15, 2021
There was a problem hiding this comment.
@attfarhan how about returning subdomain.sourcegraph.com, so as to be able to attribute traffic to the docsite, about page, etc?
I think it would be a matter of removing whatever comes after the first / or ?
|
@malomarrec the docs site and about page were not affected by this at all (see my comment in Slack and in the original PR). It's only exact when the hostname is EXACTLY |
malomarrec
approved these changes
Jul 15, 2021
eseliger
approved these changes
Jul 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of https://github.com/sourcegraph/sourcegraph/pull/22747#issuecomment-879764196
@malomarrec wants to distinguish referrers between direct traffic (which have an empty referrer) and navigation from within sourcegraph.com.
For Sourcegraph.com URLs, show the referrer as just sourcegraph.com, and remove all pathnames/query params to avoid leaking private repo/file names and search queries.