Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Code insights: Implement delete insights with new dashboard functionality #22886

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

vovakulikov
Copy link
Contributor

@vovakulikov vovakulikov commented Jul 15, 2021

Context

We always have this core insight functionality but with the dashboards system, we missed that at some point. This PR brings this functionality back. Currently, we have delete item in the insight context menu component. By click on that, you will delete this insight from all settings subjects and exclude this insight from all code insights dashboards.

image

Knowing issues

What have been done

  • Extract edit operations concept from the edit insight page
  • Re-write use-delete-insight handler taking into account new code insight dashboard system
  • Connect handler and UI

@vovakulikov vovakulikov added code-insights Issues related to the Code Insights product code-insights-dashboard labels Jul 15, 2021
@vovakulikov vovakulikov self-assigned this Jul 15, 2021
@vovakulikov vovakulikov marked this pull request as ready for review July 15, 2021 20:34
Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vovakulikov vovakulikov merged commit 9d7cbea into main Jul 16, 2021
@vovakulikov vovakulikov deleted the code-insights/dashboard-delete-insight branch July 16, 2021 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code-insights Issues related to the Code Insights product code-insights-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants