This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
repos: Make streaming syncer the default #22948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the streaming syncer the default mode, while giving admins the option to disable it by setting the env var to false. We've been running this in production for about a week without any major problems apart from a small bug that only affected sourcegraph.com in practice (that was fixed in #22947). Making it the default will benefit large customers already and allow us to start deleting old code paths.
unknwon
approved these changes
Jul 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the streaming syncer the default mode, while giving admins the option to disable it by setting the env var to false.
We've been running this in production for about a week without any major problems apart from a small bug that only affected sourcegraph.com in practice (that was fixed in #22947).
Making it the default for the next release (branch cut on Tuesday) will benefit large customers already and allow us to start deleting old code paths.