This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
insights: added graphQL arguments to filter an insights query #23256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ude / exclude regex strings
|
Notifying subscribers in CODENOTIFY files for diff 1a19d3c...77a3bde.
|
efritz
approved these changes
Jul 26, 2021
emidoots
approved these changes
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23236
Adds a very basic regex filtering to the current insights GraphQL query that operates on include / exclude. The performance isn't amazing because this doesn't reduce the cross-join happening, but it isn't significantly worse (marginally worse on my laptop).
I have some tests on another branch that for some reason are behaving weirdly. I wanted to get this out to unblock the frontend folks and will add those back in tomorrow.