Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Insights/recording with store #23279

Merged
merged 8 commits into from
Jul 27, 2021
Merged

Insights/recording with store #23279

merged 8 commits into from
Jul 27, 2021

Conversation

coury-clark
Copy link
Contributor

Closes #22812

Migrates the code insights indexed recorder to be backed by the database instead of directly out of settings.

@coury-clark coury-clark added the code-insights Issues related to the Code Insights product label Jul 27, 2021
@coury-clark coury-clark requested review from efritz and emidoots July 27, 2021 21:14
@coury-clark coury-clark self-assigned this Jul 27, 2021
efritz
efritz reviewed Jul 27, 2021
View reviewed changes
enterprise/internal/insights/background/insight_enqueuer.go
for _, insight := range foundInsights {
for _, series := range insight.Series {
seriesID := discovery.Encode(series)
if err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jul 27, 2021 •
edited
Loading

Notifying subscribers in CODENOTIFY files for diff d2b78b1...8f330e2.

Notify File(s)
@felixfbecker enterprise/internal/insights/background/background.go
enterprise/internal/insights/background/insight_enqueuer.go
enterprise/internal/insights/background/insight_enqueuer_test.go
enterprise/internal/insights/store/gen.go
enterprise/internal/insights/store/insight_store.go
enterprise/internal/insights/store/insight_store_test.go
enterprise/internal/insights/store/mock_store_dataseriesstore.go
@slimsag enterprise/internal/insights/background/background.go
enterprise/internal/insights/background/insight_enqueuer.go
enterprise/internal/insights/background/insight_enqueuer_test.go
enterprise/internal/insights/store/gen.go
enterprise/internal/insights/store/insight_store.go
enterprise/internal/insights/store/insight_store_test.go
enterprise/internal/insights/store/mock_store_dataseriesstore.go

@coury-clark coury-clark merged commit b41d042 into main Jul 27, 2021
@coury-clark coury-clark deleted the insights/recording-with-store branch July 27, 2021 23:10
@coury-clark coury-clark linked an issue Jul 29, 2021 that may be closed by this pull request
insights: Modify indexed recorder to execute based on persisted state #22820
Closed
@coury-clark coury-clark mentioned this pull request Jul 29, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@efritz efritz efritz approved these changes

@emidoots emidoots Awaiting requested review from emidoots

Assignees

@coury-clark coury-clark

Labels
code-insights Issues related to the Code Insights product
Projects
None yet
Milestone
No milestone
3 participants
@coury-clark @sourcegraph-bot @efritz