This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Pr ed iss 4 #34340
Merged
Pr ed iss 4 #34340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated the operations guide and made updates to the Docker Single Container page.
Added correct heading.
Large updates to accommodate the consolidation of Docker Compose docs and specifics related to upgrades and migration.
This should prevent someone from re-introducing them without realizing that these cause a slowdown in build times.
…tation link/email (#33577)
…d point to the primary postgres instance instead (#33469)
Previously the regexp required the test plan anchor to be at the start of a line, which fails on PRs with poorly formatted markdown. This changes the regexp to allow the test plan anchor to show up anywhere
* drop unused code monitor columns Now that we store the result contents, these columns are unused and can be removed. * regenerate schema * idempotency
* Add insight card abstraction * Adjust lang stats live preview chart * Fix default code insights backend ts types
Non go files can also affect the outcome of go build (embed) and go test (testdata). We hardcode a list of directories which mostly contain go code and run go steps if a change includes them. A recent example of this is where I only modified a file we go:embed which caused the tests to fail. However, CI did not run the tests on the PR leading to a failure on main. Test Plan: go test
We have a few places in the code where we request a burst larger than 1 so this gives us some headroom. It doesn't appear to be an issue yet so this is just a safety measure.
* Update docs as Code Insights no longer uses TimescaleDB
We now want to update dogfood as well. We also change the script to use the update-images.py helper. Additionally I added a helpful error message if build has no arguments. In particular how to check the current version. Test Plan: ran both scripts to build 0.1.16
) The logic to load search parameters from user settings only accounted for search parameters passed as actual URL parameters, not as part of the search query. This PR changes the approach and moves the responsibility of correctly applying the settings from the user settings loading code to the query state store.
Grammar and typo fixes
Co-authored-by: ggilmore <ggilmore@users.noreply.github.com>
…s embedded query (#33815)
…3219) * remove caching at github client layer in favor of httpcli caching * update test to use vcr
update the stale flag docs note
We're seeing metrics being collected with names of non site owned external services, this should not be the case as we only set up collectors for site owned external services. The only way the wrong name could be coming through is if the pointer to the service that is captured by the collector closure is changed at some point. It's not clear where this could happen, but by passing the name through as a value we avoid this possibility.
Seems like the arg has been changed a few weeks ago (see 1abc1be3196fd0c4b3af160063d339ab719ce468), but only published yesterday: sourcegraph/scip-typescript@dff7f7d This changes the arg to the new version.
This fixes #33539 by using the links to the repository use the `externalHistory` and not the panel-internal memory history.
Edited deployment sections and organized pages.
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff caee1d8...ab4ea9a.
|
|
Codenotify: Notifying subscribers in OWNERS files for diff caee1d8...ab4ea9a.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Verify links get review from working group