Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Do not paste text on macOS in e2e tests #5044

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Do not paste text on macOS in e2e tests #5044

merged 1 commit into from
Aug 1, 2019

Conversation

mrnugget
Copy link
Contributor

@mrnugget mrnugget commented Aug 1, 2019

Pasting text was introduced in f2365a5 and doesn't work on my macOS machine.

Reading through puppeteer/puppeteer#1313 (and a ton of other GitHub issues and SO questions/answers) tells me that other people also couldn't get pasting via Meta+V to work on macOS with Puppeteer.

This commit adds an override for macOS while leaving the existing paste function as is.

Pasting text was introduced in f2365a5
and doesn't work on my macOS machine.

Reading through puppeteer/puppeteer#1313
tells me that other people also couldn't get pasting via Meta+V to work
on macOS with Puppeteer.

This commit adds an override for macOS while leaving the existing
`paste` function as is.
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #5044 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5044      +/-   ##
==========================================
+ Coverage   46.26%   46.26%   +<.01%     
==========================================
  Files         731      731              
  Lines       44878    44878              
  Branches     2613     2613              
==========================================
+ Hits        20763    20765       +2     
+ Misses      22107    22106       -1     
+ Partials     2008     2007       -1
Impacted Files Coverage Δ
...d/frontend/internal/authz/bitbucketserver/store.go 80.83% <0%> (+1.19%) ⬆️

@mrnugget mrnugget merged commit 31f602e into master Aug 1, 2019
@mrnugget mrnugget deleted the fix_pasting_e2e branch August 1, 2019 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants