Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Cody: Enable rg for Windows #52251

Merged
merged 3 commits into from
May 23, 2023
Merged

Cody: Enable rg for Windows #52251

merged 3 commits into from
May 23, 2023

Conversation

philipp-spiess
Copy link
Contributor

@philipp-spiess philipp-spiess commented May 22, 2023

Closes #51685

This PR does three things:

  • Adds the windows binaries for ripgrep to our builds
  • Updates the ripgrep version to the latest build
  • Ensures that the spawned window is hidden in Windows (using the windowsHide option)

With all of this, I’m happy to report that Windows now works with local context search 😎

Test plan

  • Boot up your Windows machine of choice (or gaming rig, whatever you call it)
  • Create a build of the extension on mac (pnpm run vsce:package)
  • Find a way to move the .vsix file to Windows (iCloud etc.)
  • Open a C:\ folder in VS Code on Windows (to ensure you're not running in WSL mode)
  • Remove Cody from VS Code on Windows
  • Install from VSIX... and select the archive
  • Ask it a question in an unindexed repo
image

@cla-bot cla-bot bot added the cla-signed label May 22, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label May 22, 2023
@philipp-spiess philipp-spiess changed the title Cody: Fix rg for Windows Cody: Enable rg for Windows May 23, 2023
@philipp-spiess philipp-spiess requested review from dominiccooney and a team May 23, 2023 08:44
@philipp-spiess philipp-spiess self-assigned this May 23, 2023
@philipp-spiess philipp-spiess marked this pull request as ready for review May 23, 2023 08:44
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented May 23, 2023

📖 Storybook live preview

@philipp-spiess philipp-spiess enabled auto-merge (squash) May 23, 2023 10:46
@philipp-spiess philipp-spiess merged commit a9866c2 into main May 23, 2023
@philipp-spiess philipp-spiess deleted the ps/cody-rg-win branch May 23, 2023 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cody: rg command window appears when using keyword context on Windows
3 participants