This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
grpc: retry: add test that exectures parallel requests #59490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
github-actions
bot
added
the
team/source
ggilmore
force-pushed
the
01-10-grpc_retry_add_test_that_exectures_parallel_requests
branch
2 times, most recently
from
ff9d123
to
f4118a3
Compare
eseliger
approved these changes
Jan 10, 2024
ggilmore
force-pushed
the
01-10-grpc_retry_add_test_that_exectures_parallel_requests
branch
from
f4118a3
to
c39ec5f
Compare
ggilmore
deleted the
01-10-grpc_retry_add_test_that_exectures_parallel_requests
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During https://github.com/sourcegraph/sourcegraph/pull/59487, we discovered that the existing test suite for the retry package doesn't execute any requests in parallel due to stretchr/testify#187.
This PR explicit adds some basic tests that execute Unary / Streaming requests to see if they trip the race detector.
Test plan
CI
I also opened this example PR to show how these tests would catch the issue in https://github.com/sourcegraph/sourcegraph/pull/59487: https://github.com/sourcegraph/sourcegraph/pull/59491