codeintel: handle -insecure-skip-verify in SCIP endpoint detection #1012
+20
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efritz
approved these changes
Jul 25, 2023
olafurpg
approved these changes
Jul 26, 2023
| if err := codeintelUploadFlagSet.Parse(args); err != nil { | ||
| return nil, err | ||
| return nil, false, err |
There was a problem hiding this comment.
Non-blocking: we default to "scip is not available", but it might make sense to flip the boolean and rename it into isLSIFRequired or something like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were doing SCIP detection before parsing cli flags. As SCIP detection makes a HTTP request, this meant it wasnt configured with the (global 😬) API client flags
Test plan
Ran manually to confirm flag is picked up at the correct time with ✨ print statements ✨