Add --use-special-header to gateway benchmark (PRIME-651) #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdavid
force-pushed
the
dv/gateway-benchmark-use-cody-core-gc-test-header
branch
from
dcbc1ad to
05795e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with https://linear.app/sourcegraph/issue/PRIME-651/look-into-cloudflare-settings-for-gateway-vs-dotcom-streaming.
src gateway benchmarkcommand #1124 and its cousin PRs to sg/sgcody-core-gc-testthat Security enabled for us which disables WAF (Web Application Firewall) headers for the request that contains it.The goal is to run this on a few dev machines to learn more about how Cloudflare might affect latency.
Created this PR to store and share the code we used for this particular benchmarking.
Test plan
I'm only merging this into my other branch with PR #1138.