Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: remove type: support #163

Merged
merged 1 commit into from
Oct 1, 2021
Merged

all: remove type: support #163

merged 1 commit into from
Oct 1, 2021

Conversation

keegancsmith
Copy link
Member

This was added a few years ago and was never used. Originally I added it
for supporting hierarchical queries in Sourcegraph. But we never shipped
the stuff I worked on on the Sourcegraph side, but the code remained in
Zoekt. This deletes likely one of the most significant divergences from
upstream.

We may want something like this again in the future. But according to
Rijnard it is hard to directly use this feature since it doesn't work
the same way and/or queries work in Sourcegraph. So best to remove.

This was added a few years ago and was never used. Originally I added it
for supporting hierarchical queries in Sourcegraph. But we never shipped
the stuff I worked on on the Sourcegraph side, but the code remained in
Zoekt. This deletes likely one of the most significant divergences from
upstream.

We may want something like this again in the future. But according to
Rijnard it is hard to directly use this feature since it doesn't work
the same way and/or queries work in Sourcegraph. So best to remove.
@keegancsmith keegancsmith requested review from rvantonder and a team September 30, 2021 07:38
Copy link

@rvantonder rvantonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool. it's actually not as big a diff as i thought, so yeah, makes it easier if we felt like revisiting later later

@keegancsmith keegancsmith merged commit 96c4505 into master Oct 1, 2021
@keegancsmith keegancsmith deleted the k/rm-type-repo branch October 1, 2021 07:55
keegancsmith added a commit that referenced this pull request Oct 1, 2021
This reverts commit 96c4505. This is in
fact used by Sourcegraph.
@keegancsmith
Copy link
Member Author

@rvantonder
Copy link

Oh, you know what this is Keegan, it's (strictly) logic for repoHasFile:

https://sourcegraph.com/github.com/sourcegraph/sourcegraph@1f83100fc625fc361d9cd640dc0dd64684c4da3b/-/blob/internal/search/run/repository.go?L96:84&subtree=true

It makes sense that this still exists (sorry missed that originally). We don't need type:repo for anything else. We've deprecated repoHasFile in favor of repo:contains, but have not removed repoHasFile yet. We haven't removed repoHasFile yet for <reasons>. Let's keep this around, I'll let you know when there's an update and how to go about this next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants