Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative base URIs #125

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Support relative base URIs #125

merged 1 commit into from
Nov 4, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Nov 4, 2024

See: sourcemeta/jsonschema#185
Signed-off-by: Juan Cruz Viotti jv@jviotti.com

See: sourcemeta/jsonschema#185
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti marked this pull request as ready for review November 4, 2024 15:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: b834900 Previous: 9edbfae Ratio
Compiler_Draft6_AdaptiveCard 35467673708.00001 ns/iter 35051734417.00003 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 535.4665731610769 ns/iter 547.0893387548207 ns/iter 0.98
Evaluator_Draft4_Required_Properties 795.5421535174296 ns/iter 780.5506499049568 ns/iter 1.02
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 116.52890963230247 ns/iter 102.86253340323856 ns/iter 1.13
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 69.03736824009458 ns/iter 67.92648038452695 ns/iter 1.02
Evaluator_Draft4_Items_Schema 1138.8078507814748 ns/iter 1096.2579705149492 ns/iter 1.04
Evaluator_Draft4_Nested_Object 20.482818270806526 ns/iter 20.66523578991131 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Optional 1224.5764138141938 ns/iter 1256.1800704210127 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Closed 877.2794912022508 ns/iter 893.1537513089473 ns/iter 0.98
Evaluator_Draft4_Properties_Triad_Required 1217.7622387833317 ns/iter 1244.6982861456117 ns/iter 0.98
Evaluator_Draft4_Non_Recursive_Ref 51.42379277327065 ns/iter 50.83139578130561 ns/iter 1.01
Evaluator_Draft4_Pattern_Properties_True 1358.7036540651438 ns/iter 1363.304407906155 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 68.55458495347449 ns/iter 69.21521722758182 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 66.67535387796761 ns/iter 66.53132389502042 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 195.574043892133 ns/iter 194.56141829726582 ns/iter 1.01
Evaluator_Draft6_Property_Names 651.9024281587202 ns/iter 660.2957180347348 ns/iter 0.99
Evaluator_Draft7_If_Then_Else 126.89940789510874 ns/iter 125.05969385267434 ns/iter 1.01
Evaluator_2019_09_Unevaluated_Properties 330.2884250730748 ns/iter 337.4593812602964 ns/iter 0.98
Evaluator_2019_09_OMC_JSON_V2_1 8450.44691920419 ns/iter 9100.200059498331 ns/iter 0.93
Evaluator_2020_12_Dynamic_Ref 1004.7129572534185 ns/iter 1062.1200966942129 ns/iter 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: b834900 Previous: 9edbfae Ratio
Compiler_Draft6_AdaptiveCard 57400450062.99999 ns/iter 57636355750.00001 ns/iter 1.00
Evaluator_Draft4_Meta_1_No_Callback 703.8137602983356 ns/iter 679.5458705756055 ns/iter 1.04
Evaluator_Draft4_Required_Properties 1342.653888713124 ns/iter 1376.3802477148295 ns/iter 0.98
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 125.76493362953732 ns/iter 125.64189987789447 ns/iter 1.00
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 93.13777776240141 ns/iter 92.93020050491343 ns/iter 1.00
Evaluator_Draft4_Items_Schema 1722.033656485802 ns/iter 1711.9489250370007 ns/iter 1.01
Evaluator_Draft4_Nested_Object 28.594107293870255 ns/iter 29.394247030033167 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Optional 1647.5783206180836 ns/iter 1675.6754680247382 ns/iter 0.98
Evaluator_Draft4_Properties_Triad_Closed 1350.1955259511624 ns/iter 1361.8386203704865 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Required 1702.7642042825503 ns/iter 1740.0776816566736 ns/iter 0.98
Evaluator_Draft4_Non_Recursive_Ref 78.94271819024634 ns/iter 80.01022041806549 ns/iter 0.99
Evaluator_Draft4_Pattern_Properties_True 2409.657238940978 ns/iter 2467.136798063427 ns/iter 0.98
Evaluator_Draft4_Ref_To_Single_Property 93.04398229831611 ns/iter 93.20653201878189 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 108.82913363768415 ns/iter 108.36529447167901 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 262.14158320610596 ns/iter 262.5507221122575 ns/iter 1.00
Evaluator_Draft6_Property_Names 1047.0808706726755 ns/iter 1057.276907981439 ns/iter 0.99
Evaluator_Draft7_If_Then_Else 157.6775028773201 ns/iter 157.19529043977852 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 388.6205502752591 ns/iter 387.89018326117406 ns/iter 1.00
Evaluator_2019_09_OMC_JSON_V2_1 12577.30556356171 ns/iter 12994.432464854395 ns/iter 0.97
Evaluator_2020_12_Dynamic_Ref 1268.8890366973217 ns/iter 1268.1817730153844 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: b834900 Previous: 9edbfae Ratio
Evaluator_2020_12_Dynamic_Ref 1475.9284715998413 ns/iter 1349.5029254599067 ns/iter 1.09
Evaluator_2019_09_Unevaluated_Properties 432.95942376442207 ns/iter 433.15496235738874 ns/iter 1.00
Evaluator_2019_09_OMC_JSON_V2_1 15258.296279491275 ns/iter 15037.207956288332 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 156.40255190053628 ns/iter 149.34295711418648 ns/iter 1.05
Evaluator_Draft6_Property_Names 1534.1992268832566 ns/iter 1522.2447279597807 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 772.3595388357433 ns/iter 779.9653069445231 ns/iter 0.99
Evaluator_Draft4_Required_Properties 2033.7056016634053 ns/iter 1993.0145967556655 ns/iter 1.02
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 132.4248771877694 ns/iter 137.29224417945827 ns/iter 0.96
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 103.07193433164966 ns/iter 98.86195808914209 ns/iter 1.04
Evaluator_Draft4_Items_Schema 1367.4867212629745 ns/iter 1490.1631916827027 ns/iter 0.92
Evaluator_Draft4_Nested_Object 26.749860960752315 ns/iter 26.39885709834877 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Optional 1601.9890136511904 ns/iter 1577.6284107809513 ns/iter 1.02
Evaluator_Draft4_Properties_Triad_Closed 1264.620353867155 ns/iter 1267.6214762267493 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Required 1643.612204470566 ns/iter 1665.7298827316088 ns/iter 0.99
Evaluator_Draft4_Non_Recursive_Ref 101.34559143574505 ns/iter 99.74504775003724 ns/iter 1.02
Evaluator_Draft4_Pattern_Properties_True 2204.561657223952 ns/iter 2303.2496698967375 ns/iter 0.96
Evaluator_Draft4_Ref_To_Single_Property 105.61249795218376 ns/iter 108.15110877228095 ns/iter 0.98
Evaluator_Draft4_Additional_Properties_Type 165.55943728584293 ns/iter 155.77524049661855 ns/iter 1.06
Evaluator_Draft4_Nested_Oneof 238.05061489407151 ns/iter 242.06281309865045 ns/iter 0.98
Compiler_Draft6_AdaptiveCard 65726635794 ns/iter 65542152473.99998 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Benchmark suite Current: b834900 Previous: 9edbfae Ratio
Compiler_Draft6_AdaptiveCard 41637423038.482666 ns/iter 41268218755.722046 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 493.43995735054506 ns/iter 498.23578949114005 ns/iter 0.99
Evaluator_Draft4_Required_Properties 790.8144085089381 ns/iter 795.2322071479588 ns/iter 0.99
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 111.30392825578699 ns/iter 112.57689502812502 ns/iter 0.99
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 83.73683711293471 ns/iter 77.81868029942167 ns/iter 1.08
Evaluator_Draft4_Items_Schema 1229.1169417982335 ns/iter 1132.674252637178 ns/iter 1.09
Evaluator_Draft4_Nested_Object 26.45450493110147 ns/iter 23.780168523204278 ns/iter 1.11
Evaluator_Draft4_Properties_Triad_Optional 1378.3696591160726 ns/iter 1405.6350785514094 ns/iter 0.98
Evaluator_Draft4_Properties_Triad_Closed 1172.3362953046728 ns/iter 1232.3213132139958 ns/iter 0.95
Evaluator_Draft4_Properties_Triad_Required 1406.0659509016111 ns/iter 1445.096479815648 ns/iter 0.97
Evaluator_Draft4_Non_Recursive_Ref 60.45778916493639 ns/iter 60.68443040967252 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 1918.352866025187 ns/iter 1996.2917026782777 ns/iter 0.96
Evaluator_Draft4_Ref_To_Single_Property 78.82387145448116 ns/iter 78.93504178407493 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 74.65693252111785 ns/iter 75.27785538258048 ns/iter 0.99
Evaluator_Draft4_Nested_Oneof 197.41887073420926 ns/iter 195.93334815510516 ns/iter 1.01
Evaluator_Draft6_Property_Names 789.7853267461312 ns/iter 782.985370530095 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 126.03027116221419 ns/iter 125.00938674279313 ns/iter 1.01
Evaluator_2019_09_Unevaluated_Properties 331.99229158908145 ns/iter 334.9345068409247 ns/iter 0.99
Evaluator_2019_09_OMC_JSON_V2_1 8392.836484955718 ns/iter 7848.902089835432 ns/iter 1.07
Evaluator_2020_12_Dynamic_Ref 1098.8582370548436 ns/iter 1084.9434141244456 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: b834900 Previous: 9edbfae Ratio
Compiler_Draft6_AdaptiveCard 122850338900 ns/iter 120879742699.99995 ns/iter 1.02
Evaluator_Draft4_Meta_1_No_Callback 1526.400446428917 ns/iter 1531.8491071428955 ns/iter 1.00
Evaluator_Draft4_Required_Properties 1608.1080749276603 ns/iter 1637.0704662472765 ns/iter 0.98
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 352.60069431247496 ns/iter 345.2037553207665 ns/iter 1.02
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 255.57250000003606 ns/iter 247.37549999997557 ns/iter 1.03
Evaluator_Draft4_Items_Schema 3384.856070087647 ns/iter 3613.6382538513935 ns/iter 0.94
Evaluator_Draft4_Nested_Object 115.44703125000667 ns/iter 112.18354687500208 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Optional 5044.7540000004665 ns/iter 5232.235999999375 ns/iter 0.96
Evaluator_Draft4_Properties_Triad_Closed 4100.7039282579835 ns/iter 4138.027253523922 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Required 5056.428000000324 ns/iter 5082.436607143644 ns/iter 0.99
Evaluator_Draft4_Non_Recursive_Ref 237.97982142858538 ns/iter 244.32564285713656 ns/iter 0.97
Evaluator_Draft4_Pattern_Properties_True 8008.177455357059 ns/iter 8019.122767855943 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 258.37978571425015 ns/iter 249.4134999999785 ns/iter 1.04
Evaluator_Draft4_Additional_Properties_Type 303.65517857150945 ns/iter 305.96124933468707 ns/iter 0.99
Evaluator_Draft4_Nested_Oneof 561.328900000035 ns/iter 573.5241071428326 ns/iter 0.98
Evaluator_Draft6_Property_Names 1677.8549032219605 ns/iter 1738.6296169887844 ns/iter 0.97
Evaluator_Draft7_If_Then_Else 386.1040178572139 ns/iter 387.9533482143823 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 988.2097374064778 ns/iter 961.2970708497337 ns/iter 1.03
Evaluator_2019_09_OMC_JSON_V2_1 21069.502640587107 ns/iter 21301.618750001697 ns/iter 0.99
Evaluator_2020_12_Dynamic_Ref 3095.9319561129937 ns/iter 3114.887500000155 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit a7885ab into main Nov 4, 2024
14 checks passed
@jviotti jviotti deleted the relative-base-uri-test branch November 4, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant