Skip to content

Commit

Permalink
Close fetcher on error
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewSisley committed Feb 14, 2022
1 parent b93bafe commit d5d32f4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions db/collection_get.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func (c *Collection) get(ctx context.Context, txn *Txn, key key.DocKey) (*docume
// initialize it with the primary index
err := df.Init(&c.desc, &c.desc.Indexes[0], nil, false)
if err != nil {
_ = df.Close()
return nil, err
}

Expand All @@ -59,12 +60,14 @@ func (c *Collection) get(ctx context.Context, txn *Txn, key key.DocKey) (*docume
// run the doc fetcher
err = df.Start(ctx, txn, core.Spans{core.NewSpan(targetKey, targetKey.PrefixEnd())})
if err != nil {
_ = df.Close()
return nil, err
}

// return first matched decoded doc
doc, err := df.FetchNextDecoded(ctx)
if err != nil {
_ = df.Close()
return nil, err
}

Expand Down

0 comments on commit d5d32f4

Please sign in to comment.