ci: Integrate GitHub Action for golangci-lint Annotations #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushed to master and develop branches or tags with pattern "v*".
minutes). Easily can turn those on in future is needed.
[ci skip]
experiment one more time with the `--issues-exit-code=0` to ensure it actually does what I think it does.
… linter github workflow check should pass.
Closed
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…ork#106) This PR adds a GitHub action check with annotations supported by golangci-lint. For now I have set `-issues-exit-code=1` (workflow shows failure if even a single lint error) and to show all lint error annotations (this works for us because we will always be in a lint-error free state). In case we want to suppress lint errors we just use `nolint:xyz` (also won't show up in annotations either).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub action check with annotations supported by golangci-lint.
For now I have set
-issues-exit-code=1(workflow shows failure if even a single lint error) and to show all lint error annotations (this works for us because we will always be in a lint-error free state). In case we want to suppress lint errors we just usenolint:xyz(also won't show up in annotations either).