Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tests for defining field whose name clashes with foo_id field #1468

Closed
AndrewSisley opened this issue May 8, 2023 · 0 comments · Fixed by #1521
Closed

No tests for defining field whose name clashes with foo_id field #1468

AndrewSisley opened this issue May 8, 2023 · 0 comments · Fixed by #1521
Assignees
@AndrewSisley
Labels
area/schema Related to the schema system code quality Related to improving code quality
Milestone
DefraDB v0.6

Comments

@AndrewSisley
Copy link
Contributor

For example, we have no tests for this schema:

type Foo {
    bar: Bar
    bar_id: Int // Odd, but this clashes with the auto-generated `bar_id: ID` field and I dont know what will happen
}
type Bar {
    foo: [Foo]
}
@AndrewSisley AndrewSisley added area/schema Related to the schema system code quality Related to improving code quality labels May 8, 2023
@AndrewSisley AndrewSisley self-assigned this May 18, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.6 milestone May 18, 2023
@AndrewSisley AndrewSisley mentioned this issue May 18, 2023
Merged
AndrewSisley added a commit that referenced this issue May 18, 2023
@AndrewSisley
test: Add tests for foo_id field name clashes (#1521)
b24d5b4 
## Relevant issue(s)

Resolves #1468 

## Description

Adds tests for foo_id field name clashes with relational id fields.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
test: Add tests for foo_id field name clashes (sourcenetwork#1521)
b57ee98 
## Relevant issue(s)

Resolves sourcenetwork#1468 

## Description

Adds tests for foo_id field name clashes with relational id fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/schema Related to the schema system code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging a pull request may close this issue.

test: Add tests for foo_id field name clashes AndrewSisley/defradb
1 participant
@AndrewSisley