Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change detector bug due to not skipping some mutation tests #1849

Closed
shahzadlone opened this issue Sep 7, 2023 · 0 comments · Fixed by #1850
Closed

Fix change detector bug due to not skipping some mutation tests #1849

shahzadlone opened this issue Sep 7, 2023 · 0 comments · Fixed by #1850
Assignees
@AndrewSisley
Labels
area/testing Related to any test or testing suite bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it.

Comments

@shahzadlone
Copy link
Member

The change detector action on develop seems to be failing, this is because some mutation tests should be skipped for the change detector but aren't because the skip is handled within the mutation action handlers (only ran on the setup side).

Failed Run:
https://github.com/sourcenetwork/defradb/actions/runs/6103214759/job/16563218995
@shahzadlone shahzadlone added bug Something isn't working area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. labels Sep 7, 2023
@AndrewSisley AndrewSisley self-assigned this Sep 7, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.7 milestone Sep 7, 2023
@AndrewSisley AndrewSisley mentioned this issue Sep 7, 2023
Merged
AndrewSisley added a commit that referenced this issue Sep 7, 2023
@AndrewSisley
test(i): Skip unsupported mutation types at test level (#1850)
ebad3eb 
## Relevant issue(s)

Resolves #1849

## Description

Skips unsupported mutation types at test level.

Earlier version caused the change detector to fail, as the skip was only
executed in the setup stage, not the main/assert stage resulting in test
failures. I also think this location makes much more sense, as the skip
is a test-level thing, not something that acts at the action-level.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
test(i): Skip unsupported mutation types at test level (sourcenetwork…
ce19f10 
…#1850)

## Relevant issue(s)

Resolves sourcenetwork#1849

## Description

Skips unsupported mutation types at test level.

Earlier version caused the change detector to fail, as the skip was only
executed in the setup stage, not the main/assert stage resulting in test
failures. I also think this location makes much more sense, as the skip
is a test-level thing, not something that acts at the action-level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite bug Something isn't working ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(i): Skip unsupported mutation types at test level AndrewSisley/defradb
2 participants
@shahzadlone @AndrewSisley