Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node config refactor #2295

Closed
Tracked by #2257
nasdf opened this issue Feb 8, 2024 · 0 comments · Fixed by #2296
Closed
Tracked by #2257

Node config refactor #2295

nasdf opened this issue Feb 8, 2024 · 0 comments · Fixed by #2296
Assignees
@nasdf
Labels
area/config Related to configuration
Milestone
DefraDB v0.10

Comments

@nasdf
Copy link
Member

nasdf commented Feb 8, 2024 •
edited
Loading

Node configuration can be refactored into a new package that simplifies the setup of a DefraDB instance with optional sub-systems.
This was referenced Feb 8, 2024
Closed
Merged
@fredcarle fredcarle added the area/config Related to configuration label Feb 8, 2024
@fredcarle fredcarle added this to the DefraDB v0.10 milestone Feb 8, 2024
nasdf added a commit that referenced this issue Feb 9, 2024
@nasdf
refactor: Node config (#2296)
86610d7 
## Relevant issue(s)

Resolves #2295 

## Description

This PR refactors the node setup logic into a new `node` package.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

make test

Specify the platform(s) on which this was tested:
- MacOS
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@nasdf
refactor: Node config (sourcenetwork#2296)
3bccd5e 
## Relevant issue(s)

Resolves sourcenetwork#2295 

## Description

This PR refactors the node setup logic into a new `node` package.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

make test

Specify the platform(s) on which this was tested:
- MacOS
@nasdf nasdf mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasdf nasdf

Labels
area/config Related to configuration
Projects
None yet
Milestone
DefraDB v0.10
Development

Successfully merging a pull request may close this issue.

refactor: Node config nasdf/defradb
2 participants
@nasdf @fredcarle