Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collections returned from db.getCollections don't have a loaded transaction #2384

Closed
fredcarle opened this issue Mar 6, 2024 · 1 comment · Fixed by #2385
Closed

Collections returned from db.getCollections don't have a loaded transaction #2384

fredcarle opened this issue Mar 6, 2024 · 1 comment · Fixed by #2385
Assignees
@AndrewSisley
Labels
bug Something isn't working
Milestone
DefraDB v0.10

Comments

@fredcarle
Copy link
Collaborator

fredcarle commented Mar 6, 2024 •
edited
Loading

db.getCollections take a transaction as a parameter but the returned collections aren't loaded with that transaction. This means that subsequent operations using the returned collection will operate on an implicit transaction.
@fredcarle fredcarle added the bug Something isn't working label Mar 6, 2024
@AndrewSisley
Copy link
Contributor

This affects a bunch of stuff, not just getCollections - check the refs to newCollection. I suggest adding txn as a param to newCollection.

@AndrewSisley AndrewSisley self-assigned this Mar 6, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.10 milestone Mar 6, 2024
@AndrewSisley AndrewSisley mentioned this issue Mar 6, 2024
Merged
AndrewSisley added a commit that referenced this issue Mar 6, 2024
@AndrewSisley
fix: Make returned collections respect explicit transactions (#2385)
b377876 
## Relevant issue(s)

Resolves #2384

## Description

Makes returned collections respect explicit transactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.10
Development

Successfully merging a pull request may close this issue.

fix: Make returned collections respect explicit transactions AndrewSisley/defradb
2 participants
@fredcarle @AndrewSisley