Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PatchCollection function to Store #2389

Closed
AndrewSisley opened this issue Mar 7, 2024 · 0 comments · Fixed by #2402
Closed

Add PatchCollection function to Store #2389

AndrewSisley opened this issue Mar 7, 2024 · 0 comments · Fixed by #2402
Assignees
Labels
area/collections Related to the collections system feature New feature or request
Milestone

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Mar 7, 2024

Like PatchSchema, but for CollectionDescriptions.

This is a prerequisite for moving more stuff from schema onto collection, as users will need a means to set the moved properties.

Should eventually allow the setting of indexes and ACP stuff too, but it is fine to block those off initially in order to reduce scope of the initial PR.

As the only to-be mutable property that is not index/acp and currently already on collection description is col/field name, and those properties comes with higher risk, it might be best to do this alongside #1386 or #1385 to keep things simple to start off with.

@AndrewSisley AndrewSisley added feature New feature or request area/collections Related to the collections system labels Mar 7, 2024
@AndrewSisley AndrewSisley self-assigned this Mar 7, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.10 milestone Mar 7, 2024
AndrewSisley added a commit that referenced this issue Mar 14, 2024
## Relevant issue(s)

Resolves #2389

## Description

Adds the PatchCollection command.

Mutating anything but the collection name is currently disabled, we can
expand this as we see fit, but for now I'd prefer to keep the initial PR
small.

This change means that the Collection Name is no longer always going to
be the same as the Schema Name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collections Related to the collections system feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant