Replace logging package with corelog #2405
Comments
4 tasks
nasdf
added a commit
that referenced
this issue
Mar 19, 2024
## Relevant issue(s) Resolves #2405 ## Description This PR replaces the logging package with the `corelog` library. Please review along with sourcenetwork/corelog#2 `corelog` utilizes the `log/slog` standard library package to produce structured logs. The interface is kept mostly the same with some modifications: - `Debug` and `Fatal` levels have been removed - `context` for logging calls has been moved to a context specific variant. For example `Info` has a `InfoContext` variant. - `Feedback` methods have been removed in favor of restricting the output to `stderr` and `stdout`. - Supported output formats are `text` or `json`. `csv` is not supported by `slog` - Support for colored logs is not yet implemented, but can be easily added in a future PR. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Manually tested Specify the platform(s) on which this was tested: - MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Standardize logs by using the corelog library.
The text was updated successfully, but these errors were encountered: