Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize db/collection.go #2407

Closed
AndrewSisley opened this issue Mar 13, 2024 · 0 comments · Fixed by #2706
Closed

Reorganize db/collection.go #2407

AndrewSisley opened this issue Mar 13, 2024 · 0 comments · Fixed by #2706
Assignees
@AndrewSisley
Labels
area/collections Related to the collections system area/schema Related to the schema system
Milestone
DefraDB v0.12

Comments

@AndrewSisley
Copy link
Contributor

Currently db/collection.go contains both functions on db.collection, and functions that mutate SchemaDescription and CollectionDescription. This is worsened, but not introduced by, #2402 .

This is a bit messy and should be tidied up somehow.
@AndrewSisley AndrewSisley added area/schema Related to the schema system area/collections Related to the collections system labels Mar 13, 2024
@AndrewSisley AndrewSisley mentioned this issue Mar 13, 2024
Merged
@AndrewSisley AndrewSisley self-assigned this Jun 10, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone Jun 10, 2024
@AndrewSisley AndrewSisley mentioned this issue Jun 10, 2024
Merged
AndrewSisley added a commit that referenced this issue Jun 10, 2024
@AndrewSisley
refactor: Extract definition stuff from collection.go (#2706)
05a0932 
## Relevant issue(s)

Resolves #2407

## Description

Extracts collection create and patch, schema patch, and validation from
collection.go.

It was getting really messy in collection.go and this should hopefully
be a little better. No code has changed, only moved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/collections Related to the collections system area/schema Related to the schema system
Projects
None yet
Milestone
DefraDB v0.12
Development

Successfully merging a pull request may close this issue.

refactor: Extract definition stuff from collection.go AndrewSisley/defradb
1 participant
@AndrewSisley