Array field kinds return incorrect value for IsNillable
#2533
Assignees
Labels
bug
Something isn't working
Comments
|
It is strange that this made it into develop, we should either have integration tests that fail because of this, or it is somehow dead code and needs removal/rework. When resolving this issue, either failing tests should be added, or the code removed entirely. |
nasdf
added a commit
that referenced
this issue
Apr 20, 2024
## Relevant issue(s) Resolves #2533 ## Description This PR fixes a bug where `ScalarArrayKind.IsNillable()` returned an incorrect value for arrays of non-nillable values. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? `make test` Specify the platform(s) on which this was tested: - MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: