Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move post DAG-sync merge mechanics outside the net package. #2624

Closed
fredcarle opened this issue May 15, 2024 · 0 comments · Fixed by #2658
Closed

Move post DAG-sync merge mechanics outside the net package. #2624

fredcarle opened this issue May 15, 2024 · 0 comments · Fixed by #2658
Assignees
@fredcarle
Labels
area/crdt Related to the (Merkle) CRDT system area/p2p Related to the p2p networking system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.12

Comments

@fredcarle
Copy link
Collaborator

No description provided.

@fredcarle fredcarle added area/crdt Related to the (Merkle) CRDT system refactor This issue specific to or requires *notable* refactoring of existing codebases and components area/p2p Related to the p2p networking system labels May 15, 2024
@fredcarle fredcarle added this to the DefraDB v0.12 milestone May 15, 2024
@fredcarle fredcarle self-assigned this May 15, 2024
@fredcarle fredcarle changed the title More post DAG-sync merge mechanics outside the net package. Move post DAG-sync merge mechanics outside the net package. May 15, 2024
@fredcarle fredcarle mentioned this issue May 31, 2024
Merged
4 tasks
fredcarle added a commit that referenced this issue Jun 7, 2024
@fredcarle
refactor: DAG sync and move merge outside of net package (#2658)
0c134e5 
## Relevant issue(s)

Resolves #2624 

## Description

This PR simplifies the DAG sync process withing the `net` package and
moves the merge functionality to the `db` package. The merge is now
initiated via an event channel.

Note: I did a search and replace for `SchemaVersionId` to
`SchemaVersionID`. It's in its own commit. I've also remove the
`tests/integration/net/order` tests as they are now annoying to maintain
an will become even more irrelevant when we refactor the WaitForSync
functionality of our test framework.

Another note: I've reduced the severity of the race condition on my Mac.
We had a lot of leaking go routines and what is left of them is
WaitForSync methods that sometimes seem to leak and also badger cache
and libp2p transport that seem to leak go routines on close but I'm not
sure how to handle these last two.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/crdt Related to the (Merkle) CRDT system area/p2p Related to the p2p networking system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.12
Development

Successfully merging a pull request may close this issue.

refactor: DAG sync and move merge outside of net package fredcarle/defradb
1 participant
@fredcarle