Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change detector keeps failing due to doc encrypt test TestDocEncryption_UponEncryptionSeveralDocs_ShouldStoreAllCommitsDeltaEncrypted #2812

Closed
shahzadlone opened this issue Jul 5, 2024 · 3 comments · Fixed by #2832
Closed

Change detector keeps failing due to doc encrypt test TestDocEncryption_UponEncryptionSeveralDocs_ShouldStoreAllCommitsDeltaEncrypted #2812

shahzadlone opened this issue Jul 5, 2024 · 3 comments · Fixed by #2832
Assignees
@AndrewSisley
Labels
area/testing Related to any test or testing suite bug Something isn't working
Milestone
DefraDB v0.13

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Jul 5, 2024 •
edited
Loading

Started noticing change detector fails after rebasing the latest commit on develop: 24fa14f

Failing test: TestDocEncryption_UponEncryptionSeveralDocs_ShouldStoreAllCommitsDeltaEncrypted

Failed runs:
@shahzadlone shahzadlone added bug Something isn't working area/testing Related to any test or testing suite labels Jul 5, 2024
@shahzadlone shahzadlone added this to the DefraDB v0.13 milestone Jul 5, 2024
@islamaliev
Copy link
Contributor

how ofter does it happen?

Maybe we can try to remove all NewDocIndex calls from the related tests and replaces them with real doc ids.

@shahzadlone shahzadlone changed the title Flaky change detector due to doc encrypt test TestDocEncryption_UponEncryptionSeveralDocs_ShouldStoreAllCommitsDeltaEncrypted Change detector keeps failing due to doc encrypt test TestDocEncryption_UponEncryptionSeveralDocs_ShouldStoreAllCommitsDeltaEncrypted Jul 8, 2024
@shahzadlone shahzadlone mentioned this issue Jul 8, 2024
Merged
@islamaliev islamaliev mentioned this issue Jul 8, 2024
Merged
islamaliev added a commit that referenced this issue Jul 9, 2024
@islamaliev
feat: Doc field encryption (#2817)
d73b05b 
## Relevant issue(s)

Resolves #2809 #2812

## Description

Adds field-level encryption which allows separate fields
to be encryption with a dedicated symmetric key.
@AndrewSisley
Copy link
Contributor

Maybe we can try to remove all NewDocIndex calls from the related tests and replaces them with real doc ids.

Doc IDs should very much be consistent across processes, if they are not something is very broken and we should fix that instead of removing NewDocIndex calls

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Jul 11, 2024 •
edited
Loading

This is probably caused by the encrypted state not being deterministic: https://security.stackexchange.com/questions/42642/should-aes-always-give-the-same-output and us expecting it to be so across processes (the encrypt func used to construct expected results)

@AndrewSisley AndrewSisley self-assigned this Jul 12, 2024
@AndrewSisley AndrewSisley mentioned this issue Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.13
Development

Successfully merging a pull request may close this issue.

test: Fix refreshing of docs in change detector AndrewSisley/defradb
3 participants
@islamaliev @shahzadlone @AndrewSisley