Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL updates with default values overwrite #3029

Closed
nasdf opened this issue Sep 18, 2024 · 0 comments · Fixed by #3030
Closed

GraphQL updates with default values overwrite #3029

nasdf opened this issue Sep 18, 2024 · 0 comments · Fixed by #3030
Assignees
@nasdf
Labels
bug Something isn't working
Milestone
DefraDB v0.14

Comments

@nasdf
Copy link
Member

nasdf commented Sep 18, 2024

When a document with default values is updated via a graphql mutation any fields that are not defined in the input are set back to the default value.
@nasdf nasdf added the bug Something isn't working label Sep 18, 2024
@nasdf nasdf added this to the DefraDB v0.14 milestone Sep 18, 2024
@nasdf nasdf self-assigned this Sep 18, 2024
@nasdf nasdf mentioned this issue Sep 18, 2024
Merged
4 tasks
nasdf added a commit that referenced this issue Sep 19, 2024
@nasdf
fix(i): Default field value overwrite on update (#3030)
cddc6d6 
## Relevant issue(s)

Resolves #3029

## Description

This PR fixes an issue where default field values would overwrite any
missing input fields.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

Added integration test

Specify the platform(s) on which this was tested:
- MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasdf nasdf

Labels
bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.14
Development

Successfully merging a pull request may close this issue.

fix(i): Default field value overwrite on update nasdf/defradb
1 participant
@nasdf