Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non nill error should not return nil #3402

Closed
shahzadlone opened this issue Jan 21, 2025 · 0 comments · Fixed by #3403
Closed

Non nill error should not return nil #3402

shahzadlone opened this issue Jan 21, 2025 · 0 comments · Fixed by #3403
Assignees
@shahzadlone
Labels
code quality Related to improving code quality
Milestone
DefraDB v0.16

Comments

@shahzadlone
Copy link
Member

In light of this PR:
https://github.com/sourcenetwork/defradb/pull/3400/files

I did a rip grep search:

 rg -U "if err != nil \{\n.*return nil$"

And found one more instance in the code base where not nill error was found and still returning nil.
@shahzadlone shahzadlone added the code quality Related to improving code quality label Jan 21, 2025
@shahzadlone shahzadlone added this to the DefraDB v0.16 milestone Jan 21, 2025
@shahzadlone shahzadlone self-assigned this Jan 21, 2025
@shahzadlone shahzadlone mentioned this issue Jan 21, 2025
Merged
shahzadlone added a commit that referenced this issue Jan 21, 2025
@shahzadlone
test(i): Handle error in test setup, don't return nil (#3403)
727800a 
## Relevant issue(s)
Resolves #3402 

## Description
In light of this PR:
https://github.com/sourcenetwork/defradb/pull/3400/files

I did a rip grep search:
```
 rg -U "if err != nil \{\n.*return nil$"
```

And found one more instance in the code base where non-nill error would
still returning `nil`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.16
Development

Successfully merging a pull request may close this issue.

test(i): Handle error in test setup, don't return nil shahzadlone/defradb
1 participant
@shahzadlone