Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test for node Bootstrap #906

Closed
fredcarle opened this issue Oct 18, 2022 · 0 comments · Fixed by #1593
Closed

Improve test for node Bootstrap #906

fredcarle opened this issue Oct 18, 2022 · 0 comments · Fixed by #1593
Assignees
@fredcarle
Labels
area/network Related to internal/external network components area/p2p Related to the p2p networking system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.6

Comments

@fredcarle
Copy link
Collaborator

Logs need to be checked to ensure tests are doing what we expect them to.
@jsimnz jsimnz added refactor This issue specific to or requires *notable* refactoring of existing codebases and components area/p2p Related to the p2p networking system area/network Related to internal/external network components labels Nov 1, 2022
@jsimnz jsimnz added this to the DefraDB v0.5 milestone Nov 1, 2022
@fredcarle fredcarle self-assigned this Apr 22, 2023
@fredcarle fredcarle modified the milestones: DefraDB v0.5.1, DefraDB v0.6 May 9, 2023
@fredcarle fredcarle mentioned this issue Jun 27, 2023
Merged
4 tasks
fredcarle added a commit that referenced this issue Jul 11, 2023
@fredcarle
refactor: Merge node into net and improve coverage (#1593)
80c22b2 
## Relevant issue(s)

Resolves #906
Resolves #1123 
Resolves #1127
Resolves #1063

## Description

This PR does a refactor of the `net` package by merging into it the
`node` package. There is a considerable improvement of the test coverage
and `github.com/gogo/protobuf` is replaced with
`github.com/planetscale/vtprotobuf`.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
refactor: Merge node into net and improve coverage (sourcenetwork…
3cf1901 
…#1593)

## Relevant issue(s)

Resolves sourcenetwork#906
Resolves sourcenetwork#1123 
Resolves sourcenetwork#1127
Resolves sourcenetwork#1063

## Description

This PR does a refactor of the `net` package by merging into it the
`node` package. There is a considerable improvement of the test coverage
and `github.com/gogo/protobuf` is replaced with
`github.com/planetscale/vtprotobuf`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/network Related to internal/external network components area/p2p Related to the p2p networking system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging a pull request may close this issue.

refactor: Merge node into net and improve coverage fredcarle/defradb
3 participants
@jsimnz @fredcarle @shahzadlone