fix: Resolve aggregates' mapping with deep nested subtypes #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islamaliev
added
bug
islamaliev
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1175 +/- ##
===========================================
- Coverage 68.59% 68.42% -0.17%
===========================================
Files 180 181 +1
Lines 17012 17041 +29
===========================================
- Hits 11669 11660 -9
- Misses 4387 4415 +28
- Partials 956 966 +10
|
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results... |
|||||||||||||||
AndrewSisley
requested changes
Mar 10, 2023
There was a problem hiding this comment.
Cheers Islam - changes look good. Have two quick todo for you RE test location and framework but otherwise all good.
Not sure how I feel about getDocs 😁 but we should perhaps let it sit for a while in develop before we as a team commit to/against it.
Congrats on your first Source PR :)
tests/integration/query/one_to_many_to_one/with_sum_order_limit_test.go
Outdated
Show resolved
Hide resolved
tests/integration/query/one_to_many_to_one/with_sum_order_limit_test.go
Outdated
Show resolved
Hide resolved
fredcarle
reviewed
Mar 10, 2023
islamaliev
changed the title
islamaliev
force-pushed
the
islam/fix/panic-by-deep-nested-orderby
branch
from
ee2066d to
39c93b4
Compare
islamaliev
force-pushed
the
islam/fix/panic-by-deep-nested-orderby
branch
from
39c93b4 to
36d6867
Compare
AndrewSisley
approved these changes
Mar 14, 2023
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Fix recursive call to CloneWithoutRender * Fix deep orderby * Map properly aggregates with deep filter * Flatten test actions Update new test framework so that it allows to adding slices to the slice of actions * Switch to new testing framework Make all test in tests/integration/query/one_to_many_to_one use new testing framework
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…work#1175) * Fix recursive call to CloneWithoutRender * Fix deep orderby * Map properly aggregates with deep filter * Flatten test actions Update new test framework so that it allows to adding slices to the slice of actions * Switch to new testing framework Make all test in tests/integration/query/one_to_many_to_one use new testing framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #833 #920
Description
When resolving mapping for an aggregate it will check now if nested orderby or filter subtypes (if any) are dealing with an object (that is in a relation with the current one that the aggregate query is being running on) as opposed to just a single field on the current object.