-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(i): Integrate explain tests into test action system #1545
test(i): Integrate explain tests into test action system #1545
Conversation
Not sure why all the actions list was being passed when only description is used, in the `executeRequest` function.
expected error and actual error is a mismatch, this fixed it.
in the common fixture directory as we use the same schema for all explain tests.
to the shared common explain schema in the explain directory.
8b406c5
to
c6c8d35
Compare
This could be nice |
Codecov Report
@@ Coverage Diff @@
## develop #1545 +/- ##
===========================================
+ Coverage 72.27% 72.30% +0.03%
===========================================
Files 185 185
Lines 18374 18374
===========================================
+ Hits 13280 13286 +6
+ Misses 4052 4048 -4
+ Partials 1042 1040 -2 |
c6c8d35
to
17ba1fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, good job getting all this sorted!
Speedy, I didn't even ping any reviewers yet haha. BTW I think the new integration runs change detection on explain (and fails). I forgot if turning it off previously was intentional. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to see more lines removed than added 🙌
I thought you had - I got an email notifiication lol
They should pass, I was having a look as to why they are failing |
are not skipped now, so document to fix the breaking change detector.
LOL odd, I don't think I did. But worked for the best :)
Documented, this is probably because explain tests didn't run with change detection before (were skipped). |
…rk#1545) Resolves sourcenetwork#1243 ## Description: - [x] Integrates the new explain test setup with the new testing with action based setup. - [x] Converts all simple explain tests. - [x] Converts all default explain tests. - [x] Converts all execute explain tests. - [x] Removes the documents for default and simple tests as they aren't worth maintaining (it doesn't effect simple explain testing). - [x] Fixed a test that was being omitted due to it's file not having the extension "*_test.go".
Resolves #1243
Description:
For Reviewers:
(CORE)
commit label decorator.(RENAME)
or(UNRELATED)
label decorators can be ignored.(PREP)
label decorators are preparations needed before cleanly doing the integrations/conversions.assertion
package to store all the testing assertions as if I used theutils2.go
file instead ofexplain.go
file to put the assertion code, would have ended up with with 1700-1800 lines of code in that file, which I am not a big fan of.How has this been tested?
I have tried many permutations of manually inputting incorrect result to ensure tests don't automatically pass.