test(i): Test CreateDoc tests with gql and Collection.Save #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Time for Mercy was already defined a few lines above, and this block was essentially becoming an update, as it was being fed into collection.Save. The value has no real impact on the test as it is there to be filtered out, however it will fail when converted to a create gql request (as well as appearing quite misleading within the original test).
Will also be used by CreateDoc action soon.
AndrewSisley
added
area/query
AndrewSisley
force-pushed
the
1830-create-mut-tests
branch
from
b712f7f to
c9c0047
Compare
Codecov ReportPatch coverage has no change and project coverage change:
@@ Coverage Diff @@
## develop #1837 +/- ##
===========================================
- Coverage 75.81% 75.76% -0.05%
===========================================
Files 209 209
Lines 22261 22261
===========================================
- Hits 16875 16864 -11
- Misses 4223 4231 +8
- Partials 1163 1166 +3
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
added a commit
to AndrewSisley/defradb
that referenced
this pull request
Aug 30, 2023
shahzadlone
approved these changes
Aug 31, 2023
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…work#1837) ## Relevant issue(s) Resolves sourcenetwork#1830 ## Description Tests CreateDoc tests with gql and Collection.Save using the `mutationType` (environment) variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1830
Description
Tests CreateDoc tests with gql and Collection.Save using the
mutationType(environment) variable.