Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close fetcher on error #210

Merged
merged 1 commit into from
Feb 14, 2022
Merged

fix: Close fetcher on error #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions db/collection_get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func (c *Collection) get(ctx context.Context, txn *Txn, key key.DocKey) (*docume
// initialize it with the primary index
err := df.Init(&c.desc, &c.desc.Indexes[0], nil, false)
if err != nil {
_ = df.Close()
return nil, err
}

Expand All @@ -59,12 +60,14 @@ func (c *Collection) get(ctx context.Context, txn *Txn, key key.DocKey) (*docume
// run the doc fetcher
err = df.Start(ctx, txn, core.Spans{core.NewSpan(targetKey, targetKey.PrefixEnd())})
if err != nil {
_ = df.Close()
return nil, err
}

// return first matched decoded doc
doc, err := df.FetchNextDecoded(ctx)
if err != nil {
_ = df.Close()
return nil, err
}

Expand Down