feat: Add PN Counter CRDT type #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
feature
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2119 +/- ##
===========================================
- Coverage 74.29% 74.23% -0.06%
===========================================
Files 252 256 +4
Lines 25242 25366 +124
===========================================
+ Hits 18752 18829 +77
- Misses 5217 5261 +44
- Partials 1273 1276 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Looks good - thanks Fred. I'm approving now with a handful of small comments open, assuming that they will all be resolved sensibly.
I might have more comments/questions depending on the documentation added in db/collection.go RE todo: Please document why LLWRs should not do this, but as it is a very local issue and I'm going away please don't block the merging of this PR until I'm back if I don't get back to you in the meantime.
tests/integration/net/state/simple/peer_replicator/crdt/pncounter_test.go
Show resolved
Hide resolved
jsimnz
previously requested changes
Dec 11, 2023
islamaliev
reviewed
Dec 12, 2023
islamaliev
reviewed
Dec 12, 2023
islamaliev
reviewed
Dec 12, 2023
fredcarle
force-pushed
the
fredcarle/feat/crdt-pn-counter
branch
2 times, most recently
from
01d9b7a to
f62b2b9
Compare
AndrewSisley
reviewed
Jan 8, 2024
fredcarle
force-pushed
the
fredcarle/feat/crdt-pn-counter
branch
7 times, most recently
from
4f4ff6f to
63e011a
Compare
`cfg.LoadRootDirFromFlagOrDefault` is already called by `cfg.LoadWithRootdir`.
added a `WithCustomValues` method on `Config` to persis changes on the viper config. This will ensure that when the cli is executed, it uses the manually assigned values and not just the default.
This commit applies all the received feedback plus adds support for Float kind in for the PN Counter.
fredcarle
force-pushed
the
fredcarle/feat/crdt-pn-counter
branch
from
8d3bd46 to
f78e33b
Compare
fredcarle
dismissed
jsimnz’s stale review
Discussed in standup that we will revisit if concerns are validated in the future
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Jan 22, 2024
## Relevant issue(s) Resolves sourcenetwork#2115 ## Description This PR adds the PN Counter CRDT type. This type enforces changes that are incrementing or decrementing the value. A value cannot be set directly. The PR also simplifies the CRDT flow a bit further. For example, the `Data` field on the composite CRDT has been removed since the type links to the changed fields. This change will removes the data leak that would be present once we implement field level access control.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#2115 ## Description This PR adds the PN Counter CRDT type. This type enforces changes that are incrementing or decrementing the value. A value cannot be set directly. The PR also simplifies the CRDT flow a bit further. For example, the `Data` field on the composite CRDT has been removed since the type links to the changed fields. This change will removes the data leak that would be present once we implement field level access control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2115
Description
This PR adds the PN Counter CRDT type. This type enforces changes that are incrementing or decrementing the value. A value cannot be set directly.
The PR also simplifies the CRDT flow a bit further. For example, the
Datafield on the composite CRDT has been removed since the type links to the changed fields. This change will removes the data leak that would be present once we implement field level access control.Tasks
How has this been tested?
make test with added integrations tests
Specify the platform(s) on which this was tested: