Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add latest image tag for ghcr #2340

Merged

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #2332

Description

This PR adds the latest tag to the Github container registry release from GoReleaser.

@fredcarle fredcarle added the ci/build This is issue is about the build or CI system, and the administration of it. label Feb 25, 2024
@fredcarle fredcarle added this to the DefraDB v0.10 milestone Feb 25, 2024
@fredcarle fredcarle requested a review from a team February 25, 2024 21:42
@fredcarle fredcarle self-assigned this Feb 25, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.73%. Comparing base (392bd96) to head (b095915).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2340      +/-   ##
===========================================
+ Coverage    74.69%   74.73%   +0.04%     
===========================================
  Files          256      256              
  Lines        25254    25254              
===========================================
+ Hits         18861    18872      +11     
+ Misses        5101     5092       -9     
+ Partials      1292     1290       -2     
Flag Coverage Δ
all-tests 74.73% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392bd96...b095915. Read the comment docs.

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you tested it

@fredcarle
Copy link
Collaborator Author

LGTM assuming you tested it

I confirm.

@fredcarle fredcarle merged commit 727c883 into sourcenetwork:develop Feb 26, 2024
32 of 33 checks passed
@fredcarle fredcarle deleted the fredcarle/fix/i2332-ghcr-latest branch February 26, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest docker image for ghcr.io points to v0.7.0 not to actual latest
2 participants