Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update corelog to 0.0.7 #2547

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: Update corelog to 0.0.7 #2547

merged 2 commits into from
Apr 23, 2024

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Apr 23, 2024

Relevant issue(s)

Resolves #2546

Description

This PR updates corelog to version 0.0.7. It also adds the log.nocolor config.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added the feature New feature or request label Apr 23, 2024
@nasdf nasdf added this to the DefraDB v0.11 milestone Apr 23, 2024
@nasdf nasdf self-assigned this Apr 23, 2024
@nasdf nasdf requested a review from a team April 23, 2024 18:44
jsimnz
jsimnz approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nasdf nasdf merged commit c42e7ee into sourcenetwork:develop Apr 23, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimnz jsimnz jsimnz approved these changes

Assignees

@nasdf nasdf

Labels
feature New feature or request
Projects
None yet
Milestone
DefraDB v0.11
Development

Successfully merging this pull request may close these issues.

Update corelog to v0.0.7
2 participants
@nasdf @jsimnz