Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make node options composable #2648

Merged
merged 1 commit into from
May 24, 2024

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented May 23, 2024

Relevant issue(s)

Resolves #2642

Description

This PR fixes an issue where node subsystem options were not composable.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf self-assigned this May 23, 2024
@nasdf nasdf added the bug Something isn't working label May 23, 2024
@nasdf nasdf added this to the DefraDB v0.12 milestone May 23, 2024
@nasdf nasdf requested a review from a team May 23, 2024 21:52
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks Keenan - this should allow us to further improve the test framework stuff :)

praise: I like the solution you found to this

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup :)

@nasdf nasdf merged commit 150eb3f into sourcenetwork:develop May 24, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node options are not fully composable
3 participants