Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter with date and document with nil date value #2946

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #2945

Description

This PR ensure that no error occurs when filtering for a date while having documents with nil date value.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

added filter integration tests for date

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added bug Something isn't working area/query Related to the query component labels Aug 22, 2024
@fredcarle fredcarle requested a review from a team August 22, 2024 14:20
@fredcarle fredcarle self-assigned this Aug 22, 2024
Copy link
Contributor

@islamaliev islamaliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (53e55c4) to head (761ce7b).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2946   +/-   ##
========================================
  Coverage    79.28%   79.28%           
========================================
  Files          326      326           
  Lines        24862    24870    +8     
========================================
+ Hits         19711    19718    +7     
+ Misses        3737     3735    -2     
- Partials      1414     1417    +3     
Flag Coverage Δ
all-tests 79.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/connor/ge.go 60.00% <100.00%> (+2.42%) ⬆️
internal/connor/gt.go 60.00% <100.00%> (+2.42%) ⬆️
internal/connor/le.go 57.14% <100.00%> (+2.60%) ⬆️
internal/connor/lt.go 60.00% <100.00%> (+2.42%) ⬆️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e55c4...761ce7b. Read the comment docs.

@fredcarle fredcarle merged commit 64a2ada into sourcenetwork:develop Aug 22, 2024
41 of 42 checks passed
@fredcarle fredcarle deleted the fredcarle/fix/i2945-filter-with-nil-date-value branch August 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some filters break with dates
2 participants